Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -250 lines) Patch
M xfa/src/fxbarcode/BC_BinaryBitmap.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitMatrix.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteArray.cpp View 1 3 chunks +8 lines, -15 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteMatrix.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonDecoderResult.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixBitMatrixParser.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecoder.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixReader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixVersion.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDReader.cpp View 1 3 chunks +4 lines, -15 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimReader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 10 chunks +10 lines, -13 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResult.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultColumn.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp View 1 5 chunks +7 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.cpp View 1 6 chunks +7 lines, -11 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoder.cpp View 1 2 chunks +5 lines, -17 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBitVector.cpp View 1 2 chunks +3 lines, -12 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBlockPair.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetectorResult.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-24 02:45:26 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/1726373002/diff/1/xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp File xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp (right): https://codereview.chromium.org/1726373002/diff/1/xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp#newcode61 xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp:61: FindGuardPattern(row, rowOffset, TRUE, &result, e); nit: at some ...
4 years, 10 months ago (2016-02-24 03:03:36 UTC) #3
Lei Zhang
https://codereview.chromium.org/1726373002/diff/1/xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp File xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp (right): https://codereview.chromium.org/1726373002/diff/1/xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp#newcode61 xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp:61: FindGuardPattern(row, rowOffset, TRUE, &result, e); On 2016/02/24 03:03:36, dsinclair ...
4 years, 10 months ago (2016-02-24 23:26:45 UTC) #4
Lei Zhang
4 years, 10 months ago (2016-02-24 23:26:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
38eaaf36b09b816b963015e33dc4eb02580e0462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698