xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp b/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp

index 73999a4818c58a103347bdf971d1f7a85c764891..5f0ad98d65abf20073ddc6bd9e4b9e0a40405b62 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp

@@ -58,10 +58,7 @@ CFX_ByteString CBC_OnedCode39Reader::DecodeRow(int32_t rowNumber,

CFX_Int32Array* start = FindAsteriskPattern(row, e);

BC_EXCEPTION_CHECK_ReturnValue(e, "");

int32_t nextStart = (*start)[1];

- if (start != NULL) {

- delete start;

- start = NULL;

- }

+ delete start;

int32_t end = row->GetSize();

while (nextStart < end && !row->Get(nextStart)) {

nextStart++;