xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

diff --git a/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp b/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

index 993b9c526a0da9b0a19bebfe16ef8c67d8bba80c..e5002ce6eede87982b49cbaded1b56dd52764fa1 100644

--- a/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

+++ b/xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

@@ -60,14 +60,8 @@ void CBC_ReedSolomonGF256::Init() {

m_one = new CBC_ReedSolomonGF256Poly(this, 1);

}

CBC_ReedSolomonGF256::~CBC_ReedSolomonGF256() {

- if (m_zero != NULL) {

- delete m_zero;

- m_zero = NULL;

- }

- if (m_one != NULL) {

- delete m_one;

- m_one = NULL;

- }

+ delete m_zero;

+ delete m_one;

}

CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::GetZero() {

return m_zero;