xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp

diff --git a/xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp b/xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp

index b6a6f7e10b7419497112ba0792e1c72b5966d116..1fd8742690888b839bda361d02053eceb56a925f 100644

--- a/xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp

+++ b/xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp

@@ -115,7 +115,7 @@ CBC_CommonBitMatrix* CBC_QRDetector::SampleGrid(

FX_FLOAT bottomRightY;

FX_FLOAT sourceBottomRightX;

FX_FLOAT sourceBottomRightY;

- if (alignmentPattern != NULL) {

+ if (alignmentPattern) {

bottomRightX = alignmentPattern->GetX();

bottomRightY = alignmentPattern->GetY();

sourceBottomRightX = sourceBottomRightY = dimMinusThree - 3.0f;