Remove foo != NULL checks in xfa/src/fxbarcode.

xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2013 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 52 matching lines @@
     int32_t minCodewordWidth,
     int32_t maxCodewordWidth,
     int32_t& e) {
   CBC_BoundingBox* boundingBox = new CBC_BoundingBox(
       image, imageTopLeft, imageBottomLeft, imageTopRight, imageBottomRight, e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   CBC_DetectionResultRowIndicatorColumn* leftRowIndicatorColumn = NULL;
   CBC_DetectionResultRowIndicatorColumn* rightRowIndicatorColumn = NULL;
   CBC_DetectionResult* detectionResult = NULL;
   for (int32_t i = 0; i < 2; i++) {
-    if (imageTopLeft != NULL) {
+    if (imageTopLeft) {
       leftRowIndicatorColumn =
           getRowIndicatorColumn(image, boundingBox, *imageTopLeft, TRUE,
                                 minCodewordWidth, maxCodewordWidth);
     }
-    if (imageTopRight != NULL) {
+    if (imageTopRight) {
       rightRowIndicatorColumn =
           getRowIndicatorColumn(image, boundingBox, *imageTopRight, FALSE,
                                 minCodewordWidth, maxCodewordWidth);
     }
     detectionResult = merge(leftRowIndicatorColumn, rightRowIndicatorColumn, e);
     if (e != BCExceptionNO) {
       e = BCExceptiontNotFoundInstance;
       delete leftRowIndicatorColumn;
       delete rightRowIndicatorColumn;
       delete boundingBox;
@@ skipping 12 matching lines @@
   }
   int32_t maxBarcodeColumn = detectionResult->getBarcodeColumnCount() + 1;
   detectionResult->setDetectionResultColumn(0, leftRowIndicatorColumn);
   detectionResult->setDetectionResultColumn(maxBarcodeColumn,
                                             rightRowIndicatorColumn);
   FX_BOOL leftToRight = leftRowIndicatorColumn != NULL;
   for (int32_t barcodeColumnCount = 1; barcodeColumnCount <= maxBarcodeColumn;
        barcodeColumnCount++) {
     int32_t barcodeColumn = leftToRight ? barcodeColumnCount
                                         : maxBarcodeColumn - barcodeColumnCount;
-    if (detectionResult->getDetectionResultColumn(barcodeColumn) != NULL) {
+    if (detectionResult->getDetectionResultColumn(barcodeColumn)) {
       continue;
     }
     CBC_DetectionResultColumn* detectionResultColumn = NULL;
     if (barcodeColumn == 0 || barcodeColumn == maxBarcodeColumn) {
       detectionResultColumn = new CBC_DetectionResultRowIndicatorColumn(
           boundingBox, barcodeColumn == 0);
     } else {
       detectionResultColumn = new CBC_DetectionResultColumn(boundingBox);
     }
     detectionResult->setDetectionResultColumn(barcodeColumn,
                                               detectionResultColumn);
     int32_t startColumn = -1;
     int32_t previousStartColumn = startColumn;
     for (int32_t imageRow = boundingBox->getMinY();
          imageRow <= boundingBox->getMaxY(); imageRow++) {
       startColumn =
           getStartColumn(detectionResult, barcodeColumn, imageRow, leftToRight);
       if (startColumn < 0 || startColumn > boundingBox->getMaxX()) {
         if (previousStartColumn == -1) {
           continue;
         }
         startColumn = previousStartColumn;
       }
       CBC_Codeword* codeword = detectCodeword(
           image, boundingBox->getMinX(), boundingBox->getMaxX(), leftToRight,
           startColumn, imageRow, minCodewordWidth, maxCodewordWidth);
-      if (codeword != NULL) {
+      if (codeword) {
         detectionResultColumn->setCodeword(imageRow, codeword);
         previousStartColumn = startColumn;
         minCodewordWidth = minCodewordWidth < codeword->getWidth()
                                ? minCodewordWidth
                                : codeword->getWidth();
         maxCodewordWidth = maxCodewordWidth > codeword->getWidth()
                                ? maxCodewordWidth
                                : codeword->getWidth();
       }
     }
@@ skipping 154 matching lines @@
   for (int32_t i = 0; i < 2; i++) {
     int32_t increment = i == 0 ? 1 : -1;
     int32_t startColumn = (int32_t)startPoint.GetX();
     for (int32_t imageRow = (int32_t)startPoint.GetY();
          imageRow <= boundingBox->getMaxY() &&
          imageRow >= boundingBox->getMinY();
          imageRow += increment) {
       CBC_Codeword* codeword =
           detectCodeword(image, 0, image->GetWidth(), leftToRight, startColumn,
                          imageRow, minCodewordWidth, maxCodewordWidth);
-      if (codeword != NULL) {
+      if (codeword) {
         rowIndicatorColumn->setCodeword(imageRow, codeword);
         if (leftToRight) {
           startColumn = codeword->getStartX();
         } else {
           startColumn = codeword->getEndX();
         }
       }
     }
   }
   return rowIndicatorColumn;
@@ skipping 184 matching lines @@
     CBC_DetectionResult* detectionResult,
     int32_t barcodeColumn,
     int32_t imageRow,
     FX_BOOL leftToRight) {
   int32_t offset = leftToRight ? 1 : -1;
   CBC_Codeword* codeword = NULL;
   if (isValidBarcodeColumn(detectionResult, barcodeColumn - offset)) {
     codeword = detectionResult->getDetectionResultColumn(barcodeColumn - offset)
                    ->getCodeword(imageRow);
   }
-  if (codeword != NULL) {
+  if (codeword) {
     return leftToRight ? codeword->getEndX() : codeword->getStartX();
   }
   codeword = detectionResult->getDetectionResultColumn(barcodeColumn)
                  ->getCodewordNearby(imageRow);
-  if (codeword != NULL) {
+  if (codeword) {
     return leftToRight ? codeword->getStartX() : codeword->getEndX();
   }
   if (isValidBarcodeColumn(detectionResult, barcodeColumn - offset)) {
     codeword = detectionResult->getDetectionResultColumn(barcodeColumn - offset)
                    ->getCodewordNearby(imageRow);
   }
-  if (codeword != NULL) {
+  if (codeword) {
     return leftToRight ? codeword->getEndX() : codeword->getStartX();
   }
   int32_t skippedColumns = 0;
   while (isValidBarcodeColumn(detectionResult, barcodeColumn - offset)) {
     barcodeColumn -= offset;
     for (int32_t i = 0;
          i < detectionResult->getDetectionResultColumn(barcodeColumn)
                  ->getCodewords()
                  ->GetSize();
          i++) {
       CBC_Codeword* previousRowCodeword =
           (CBC_Codeword*)detectionResult->getDetectionResultColumn(
                                             barcodeColumn)
               ->getCodewords()
               ->GetAt(i);
-      if (previousRowCodeword != NULL) {
+      if (previousRowCodeword) {
         return (leftToRight ? previousRowCodeword->getEndX()
                             : previousRowCodeword->getStartX()) +
                offset * skippedColumns * (previousRowCodeword->getEndX() -
                                           previousRowCodeword->getStartX());
       }
     }
     skippedColumns++;
   }
   return leftToRight ? detectionResult->getBoundingBox()->getMinX()
                      : detectionResult->getBoundingBox()->getMaxX();
@@ skipping 186 matching lines @@
   int32_t result = getCodewordBucketNumber(*array);
   delete array;
   return result;
 }
 int32_t CBC_PDF417ScanningDecoder::getCodewordBucketNumber(
     CFX_Int32Array& moduleBitCount) {
   return (moduleBitCount.GetAt(0) - moduleBitCount.GetAt(2) +
           moduleBitCount.GetAt(4) - moduleBitCount.GetAt(6) + 9) %
          9;
 }