Remove foo != NULL checks in xfa/src/fxbarcode.

xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2008 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 40 matching lines @@
     }
   }
   int32_t RowOffsetLen = (rowOffset - rowOffsetLeft) / 4;
   CFX_Int32Array result;
   result.Add(CBC_OneDimReader::MIDDLE_PATTERN[0]);
   result.Add(CBC_OneDimReader::MIDDLE_PATTERN[1]);
   result.Add(CBC_OneDimReader::MIDDLE_PATTERN[2]);
   result.Add(CBC_OneDimReader::MIDDLE_PATTERN[3]);
   result.Add(CBC_OneDimReader::MIDDLE_PATTERN[4]);
   CFX_Int32Array* middleRange =
       FindGuardPattern(row, rowOffset, TRUE, &result, e);

[dsinclair, 2016/02/24 03:03:36]

nit: at some point, should we change FindGuardPattern to a std::unique_ptr?

[Lei Zhang, 2016/02/24 23:26:45]

Some other day.

   BC_EXCEPTION_CHECK_ReturnValue(e, 0);
   int32_t rowOffsetMid = rowOffset;
   rowOffset = (*middleRange)[1];
   if ((rowOffset - rowOffsetMid) > RowOffsetLen) {
     e = BCExceptionNotFound;
     BC_EXCEPTION_CHECK_ReturnValue(e, 0);
   }
-  if (middleRange != NULL) {
-    delete middleRange;
-    middleRange = NULL;
-  }
+  delete middleRange;
   for (int32_t y = 0; y < 4 && rowOffset < end; y++) {
     int32_t bestMatch =
         DecodeDigit(row, &counters, rowOffset,
                     &(CBC_OneDimReader::L_PATTERNS[0][0]), 10, e);
     BC_EXCEPTION_CHECK_ReturnValue(e, 0);
     resultResult += (FX_CHAR)('0' + bestMatch);
     for (int32_t i = 0; i < counters.GetSize(); i++) {
       rowOffset += counters[i];
     }
   }
   return rowOffset;
 }