xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp

diff --git a/xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp b/xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp

index fcef73acbfb19d68268cb60ecde36bdca8fa77b9..ebaa40fd12c112da748af2a496bb0f1b20bacb38 100644

--- a/xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp

+++ b/xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp

@@ -39,10 +39,7 @@ void CBC_QRCoderDecoder::Init() {

m_rsDecoder = new CBC_ReedSolomonDecoder(CBC_ReedSolomonGF256::QRCodeFild);

}

CBC_QRCoderDecoder::~CBC_QRCoderDecoder() {

- if (m_rsDecoder != NULL) {

- delete m_rsDecoder;

- }

- m_rsDecoder = NULL;

+ delete m_rsDecoder;

}

CBC_CommonDecoderResult* CBC_QRCoderDecoder::Decode(FX_BOOL* image,

int32_t width,