xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

index 8d9671089b01c04070d25bf65bce30d943911b3a..582f93bc152e1dd3ddc5a2786b1b3e7466c1d425 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

@@ -190,7 +190,7 @@ CFX_ByteString CBC_OnedCode128Reader::DecodeRow(int32_t rowNumber,

codeSet = CODE_CODE_C;

break;

default:

- if (startPatternInfo != NULL) {

+ if (startPatternInfo) {

startPatternInfo->RemoveAll();

delete startPatternInfo;

startPatternInfo = NULL;

@@ -203,7 +203,7 @@ CFX_ByteString CBC_OnedCode128Reader::DecodeRow(int32_t rowNumber,

CFX_ByteString result;

int32_t lastStart = (*startPatternInfo)[0];

int32_t nextStart = (*startPatternInfo)[1];

- if (startPatternInfo != NULL) {

+ if (startPatternInfo) {

startPatternInfo->RemoveAll();

delete startPatternInfo;

startPatternInfo = NULL;