xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp b/xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp

index 14040632a7f7e4ac0c502e864cb3f5520ca3623d..416b08ae9a8642b83c5e1056a575f6344bb90f61 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp

@@ -35,10 +35,7 @@ void CBC_OnedUPCAReader::Init() {

m_ean13Reader = new CBC_OnedEAN13Reader;

}

CBC_OnedUPCAReader::~CBC_OnedUPCAReader() {

- if (m_ean13Reader != NULL) {

- delete m_ean13Reader;

- }

- m_ean13Reader = NULL;

+ delete m_ean13Reader;

}

CFX_ByteString CBC_OnedUPCAReader::DecodeRow(int32_t rowNumber,

CBC_CommonBitArray* row,