Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp ('k') | xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2007 ZXing authors 8 * Copyright 2007 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 12 matching lines...) Expand all
23 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECB.h" 23 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECB.h"
24 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.h" 24 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.h"
25 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.h" 25 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.h"
26 #include "xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h" 26 #include "xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h"
27 #include "xfa/src/fxbarcode/utils.h" 27 #include "xfa/src/fxbarcode/utils.h"
28 28
29 CBC_QRDataBlock::CBC_QRDataBlock(int32_t numDataCodewords, 29 CBC_QRDataBlock::CBC_QRDataBlock(int32_t numDataCodewords,
30 CFX_ByteArray* codewords) 30 CFX_ByteArray* codewords)
31 : m_numDataCodewords(numDataCodewords), m_codewords(codewords) {} 31 : m_numDataCodewords(numDataCodewords), m_codewords(codewords) {}
32 CBC_QRDataBlock::~CBC_QRDataBlock() { 32 CBC_QRDataBlock::~CBC_QRDataBlock() {
33 if (m_codewords != NULL) { 33 delete m_codewords;
34 delete m_codewords;
35 m_codewords = NULL;
36 }
37 } 34 }
38 int32_t CBC_QRDataBlock::GetNumDataCodewords() { 35 int32_t CBC_QRDataBlock::GetNumDataCodewords() {
39 return m_numDataCodewords; 36 return m_numDataCodewords;
40 } 37 }
41 CFX_ByteArray* CBC_QRDataBlock::GetCodewords() { 38 CFX_ByteArray* CBC_QRDataBlock::GetCodewords() {
42 return m_codewords; 39 return m_codewords;
43 } 40 }
44 CFX_PtrArray* CBC_QRDataBlock::GetDataBlocks( 41 CFX_PtrArray* CBC_QRDataBlock::GetDataBlocks(
45 CFX_ByteArray* rawCodewords, 42 CFX_ByteArray* rawCodewords,
46 CBC_QRCoderVersion* version, 43 CBC_QRCoderVersion* version,
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 int32_t max = ((CBC_QRDataBlock*)(*result)[0])->m_codewords->GetSize(); 100 int32_t max = ((CBC_QRDataBlock*)(*result)[0])->m_codewords->GetSize();
104 for (i = shorterBlocksNumDataCodewords; i < max; i++) { 101 for (i = shorterBlocksNumDataCodewords; i < max; i++) {
105 for (int32_t y = 0; y < numResultBlocks; y++) { 102 for (int32_t y = 0; y < numResultBlocks; y++) {
106 int32_t iOffset = y < longerBlocksStartAt ? i : i + 1; 103 int32_t iOffset = y < longerBlocksStartAt ? i : i + 1;
107 (*(((CBC_QRDataBlock*)(*result)[y])->m_codewords))[iOffset] = 104 (*(((CBC_QRDataBlock*)(*result)[y])->m_codewords))[iOffset] =
108 (*rawCodewords)[rawCodewordsOffset++]; 105 (*rawCodewords)[rawCodewordsOffset++];
109 } 106 }
110 } 107 }
111 return result.release(); 108 return result.release();
112 } 109 }
OLDNEW
« no previous file with comments | « xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp ('k') | xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698