S390: Initial impl of S390 asm, masm, code-stubs,...

S390: Initial impl of S390 asm, masm, code-stubs,...

Initial commit with the bulk of the src/s390/* changes
along with associated changes to the build toolchain for
the new files.

A minor update to V8PRIuPTR definition for Mac OS X
affecting 32-bit S390 sim compilations.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/23cf65926e699105347a7ea474d4198231103852
Cr-Commit-Position: refs/heads/master@{#34331}

[JoranSiu, 2016-02-24 23:28:35]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 23:28:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725243004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725243004/1

[commit-bot: I haz the power, 2016-02-24 23:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 23:29:51]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/1875)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[JoranSiu, 2016-02-25 01:16:28]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 01:16:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725243004/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725243004/10001

[commit-bot: I haz the power, 2016-02-25 01:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 01:34:11]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[jochen (gone - plz use gerrit), 2016-02-25 12:17:28]

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn#oldcode233
BUILD.gn:233: "src/js/macros.py",
the order of files here matters iirc

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn#newcode231
BUILD.gn:231: "tools/jsmin.py",
I assume these changes are from "gn format"?

https://codereview.chromium.org/1725243004/diff/10001/src/s390/cpu-s390.cc
File src/s390/cpu-s390.cc (right):

https://codereview.chromium.org/1725243004/diff/10001/src/s390/cpu-s390.cc#ne...
src/s390/cpu-s390.cc:29:
Simulator::FlushICache(Isolate::Current()->simulator_i_cache(), buffer, size);
please don't use Isolate::Current()

[JoranSiu, 2016-02-25 14:31:29]

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn#oldcode233
BUILD.gn:233: "src/js/macros.py",
On 2016/02/25 12:17:28, jochen wrote:
> the order of files here matters iirc

Acknowledged.

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1725243004/diff/10001/BUILD.gn#newcode231
BUILD.gn:231: "tools/jsmin.py",
On 2016/02/25 12:17:28, jochen wrote:
> I assume these changes are from "gn format"?

These formatting changes were actually part of 'cl format'.  I wasn't aware of
'gn format' until you mentioned it. I'll re-commit with 'gn format'.  Thanks!

[JoranSiu, 2016-02-25 18:56:45]

@jochen, thanks for the review comments.  The latest patch set contains an
updated BUILD.gn + cpu-s390.cc .  There isn't a 'gn format', so I simply took
the original, and added the new s390 files we are introducing in this patch.

[jochen (gone - plz use gerrit), 2016-02-26 12:11:14]

lgtm with comment

https://codereview.chromium.org/1725243004/diff/30001/src/s390/assembler-s390.h
File src/s390/assembler-s390.h (right):

https://codereview.chromium.org/1725243004/diff/30001/src/s390/assembler-s390...
src/s390/assembler-s390.h:35: // Copyright 2014 the V8 project authors. All
rights reserved.
please update the year in V8 copyright headers to 2016

[JoranSiu, 2016-02-26 13:13:56]

On 2016/02/26 12:11:14, jochen wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/1725243004/diff/30001/src/s390/assembler-s390.h
> File src/s390/assembler-s390.h (right):
> 
>
https://codereview.chromium.org/1725243004/diff/30001/src/s390/assembler-s390...
> src/s390/assembler-s390.h:35: // Copyright 2014 the V8 project authors. All
> rights reserved.
> please update the year in V8 copyright headers to 2016

The years currently reflect the year we started writing those files.  Is the
practice to update them to 2016 to reflect when they are contributed into V8?

[jochen (gone - plz use gerrit), 2016-02-26 15:04:53]

that's a good question.

Usually, the year of writing is the same as the year when a CL gets submitted...
of course, here it's a different situation, so I leave the decision up to you

[JoranSiu, 2016-02-26 15:18:01]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 15:18:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725243004/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725243004/30001

[commit-bot: I haz the power, 2016-02-26 15:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 15:39:30]

Dry run: This issue passed the CQ dry run.

[JoranSiu, 2016-02-26 16:06:37]

Thanks @jochen.  I'll keep the copyright as is.   Our changes have evolved as we
ported against the older V8 levels used in Node.js over the past 2 years.  :)

[JoranSiu, 2016-02-26 16:22:08]

The CQ bit was checked by joransiu@ca.ibm.com

[commit-bot: I haz the power, 2016-02-26 16:22:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725243004/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725243004/30001

[commit-bot: I haz the power, 2016-02-26 16:24:44]

Committed patchset #4 (id:30001)

[commit-bot: I haz the power, 2016-02-26 16:25:13]

Description was changed from

==========
S390: Initial impl of S390 asm, masm, code-stubs,...

Initial commit with the bulk of the src/s390/* changes
along with associated changes to the build toolchain for
the new files.

A minor update to V8PRIuPTR definition for Mac OS X
affecting 32-bit S390 sim compilations.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=
==========

to

==========
S390: Initial impl of S390 asm, masm, code-stubs,...

Initial commit with the bulk of the src/s390/* changes
along with associated changes to the build toolchain for
the new files.

A minor update to V8PRIuPTR definition for Mac OS X
affecting 32-bit S390 sim compilations.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=

Committed: https://crrev.com/23cf65926e699105347a7ea474d4198231103852
Cr-Commit-Position: refs/heads/master@{#34331}
==========

[commit-bot: I haz the power, 2016-02-26 16:25:15]

Patchset 4 (id:??) landed as
https://crrev.com/23cf65926e699105347a7ea474d4198231103852
Cr-Commit-Position: refs/heads/master@{#34331}