Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1664993002: Fix asm-wasm.js test. (Closed)

Created:
4 years, 10 months ago by aseemgarg
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix asm-wasm.js test. R=bradnelson@chromium.org BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=asm-wasm.js LOG=N Committed: https://crrev.com/66018a0ea8e6ac7c7ce5ec45cf40e98c78ca17d7 Cr-Commit-Position: refs/heads/master@{#33713}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -31 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 1 3 chunks +93 lines, -31 lines 0 comments Download
A src/wasm/switch-logic.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A src/wasm/switch-logic.cc View 1 1 chunk +58 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
aseemgarg
4 years, 10 months ago (2016-02-03 22:11:16 UTC) #1
bradn
lgtm
4 years, 10 months ago (2016-02-03 22:13:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664993002/1
4 years, 10 months ago (2016-02-03 22:13:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10487)
4 years, 10 months ago (2016-02-03 22:16:36 UTC) #8
bradnelson
lgtm
4 years, 10 months ago (2016-02-03 22:38:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664993002/1
4 years, 10 months ago (2016-02-03 22:38:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 22:40:18 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:40:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66018a0ea8e6ac7c7ce5ec45cf40e98c78ca17d7
Cr-Commit-Position: refs/heads/master@{#33713}

Powered by Google App Engine
This is Rietveld 408576698