Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2724973003: [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions (Closed)

Created:
3 years, 9 months ago by aseemgarg
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions This fixes and relands https://codereview.chromium.org/2718323003. R=bbudge@chromium.org,titzer@chromium.org,ahaas@chromium.org,machenbach@chromium.org,bradnelson@chromium.org BUG=v8:6020 Review-Url: https://codereview.chromium.org/2724973003 Cr-Commit-Position: refs/heads/master@{#43561} Committed: https://chromium.googlesource.com/v8/v8/+/81ad6b521fc070542fa09964a0f5451759c89680

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -47 lines) Patch
M src/compiler/simd-scalar-lowering.h View 1 2 4 chunks +16 lines, -15 lines 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 6 chunks +165 lines, -21 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 6 chunks +9 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
aseemgarg
The earlier commit failed because Float64RoundTruncate wasn't supported on the failing bot. Fixed it to ...
3 years, 9 months ago (2017-03-02 00:21:45 UTC) #1
bbudge
lgtm
3 years, 9 months ago (2017-03-02 00:42:28 UTC) #2
Mircea Trofin
On 2017/03/02 00:42:28, bbudge wrote: > lgtm lgtm, one nit
3 years, 9 months ago (2017-03-03 01:26:41 UTC) #6
Mircea Trofin
https://codereview.chromium.org/2724973003/diff/20001/src/compiler/simd-scalar-lowering.h File src/compiler/simd-scalar-lowering.h (right): https://codereview.chromium.org/2724973003/diff/20001/src/compiler/simd-scalar-lowering.h#newcode69 src/compiler/simd-scalar-lowering.h:69: struct NodeState { while here, mind moving this struct ...
3 years, 9 months ago (2017-03-03 01:26:51 UTC) #7
aseemgarg
https://codereview.chromium.org/2724973003/diff/20001/src/compiler/simd-scalar-lowering.h File src/compiler/simd-scalar-lowering.h (right): https://codereview.chromium.org/2724973003/diff/20001/src/compiler/simd-scalar-lowering.h#newcode69 src/compiler/simd-scalar-lowering.h:69: struct NodeState { On 2017/03/03 01:26:50, Mircea Trofin wrote: ...
3 years, 9 months ago (2017-03-03 01:35:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724973003/40001
3 years, 9 months ago (2017-03-03 01:36:49 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:04:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/81ad6b521fc070542fa09964a0f5451759c...

Powered by Google App Engine
This is Rietveld 408576698