[wasm] allow array access with unsigned indices

[wasm] allow array access with unsigned indices

BUG=618608
R=bradnelson@chromium.org
TEST=regress-618608.js

Committed: https://crrev.com/cd95c600beab202655b328e54845a468f72bfb0d
Cr-Commit-Position: refs/heads/master@{#37693}

[bradnelson, 2016-07-11 22:40:24]

https://codereview.chromium.org/2138243002/diff/1/src/asmjs/typing-asm.cc
File src/asmjs/typing-asm.cc (right):

https://codereview.chromium.org/2138243002/diff/1/src/asmjs/typing-asm.cc#new...
src/asmjs/typing-asm.cc:783: RECURSE(VisitWithExpectation(bin->left(),
cache_.kAsmInt,
I think this can only be int for int8 / uint8

[bradn, 2016-07-11 23:02:58]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-07-11 23:02:59]

https://codereview.chromium.org/2138243002/diff/1/src/asmjs/typing-asm.cc
File src/asmjs/typing-asm.cc (right):

https://codereview.chromium.org/2138243002/diff/1/src/asmjs/typing-asm.cc#new...
src/asmjs/typing-asm.cc:783: RECURSE(VisitWithExpectation(bin->left(),
cache_.kAsmInt,
On 2016/07/11 22:40:24, bradnelson wrote:
> I think this can only be int for int8 / uint8

nm, you are correct.

[bradnelson, 2016-07-11 23:05:04]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-07-11 23:05:05]

lgtm

[commit-bot: I haz the power, 2016-07-11 23:05:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 23:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:18:46]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[aseemgarg, 2016-07-12 01:01:56]

The CQ bit was checked by aseemgarg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 01:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:27:53]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-07-12 21:52:28]

still lgtm

[bradn, 2016-07-12 21:52:33]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-07-12 21:52:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2138243002/#ps20001
(title: "[wasm] allow array access with unsigned indices")

[commit-bot: I haz the power, 2016-07-12 21:52:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:55:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 21:56:49]

Description was changed from

==========
[wasm] allow array access with unsigned indices

BUG=618608
R=bradnelson@chromium.org
TEST=regress-618608.js
==========

to

==========
[wasm] allow array access with unsigned indices

BUG=618608
R=bradnelson@chromium.org
TEST=regress-618608.js

Committed: https://crrev.com/cd95c600beab202655b328e54845a468f72bfb0d
Cr-Commit-Position: refs/heads/master@{#37693}
==========

[commit-bot: I haz the power, 2016-07-12 21:56:50]

Patchset 2 (id:??) landed as
https://crrev.com/cd95c600beab202655b328e54845a468f72bfb0d
Cr-Commit-Position: refs/heads/master@{#37693}