Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1869183002: Debug error (Closed)

Created:
4 years, 8 months ago by aseemgarg
Modified:
4 years, 8 months ago
Reviewers:
titzer, bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
aseemgarg
Hey Andreas, Ben I get an error in webassembly when I try to subtract 0 ...
4 years, 8 months ago (2016-04-07 22:01:59 UTC) #1
ahaas
On 2016/04/07 at 22:01:59, aseemgarg wrote: > Hey Andreas, Ben > I get an error ...
4 years, 8 months ago (2016-04-08 11:25:39 UTC) #2
ahaas
4 years, 8 months ago (2016-04-21 06:57:56 UTC) #3
On 2016/04/08 at 11:25:39, ahaas wrote:
> On 2016/04/07 at 22:01:59, aseemgarg wrote:
> > Hey Andreas, Ben
> > I get an error in webassembly when I try to subtract 0 from a variable and
run with the --debug_code flag.
> > Can one of you take a look? I've isolated the error in a test.
> > The error is "abort: 32 bit value in register is not zero-extended"
> 
> I fixed the problem in https://codereview.chromium.org/1867293002. Thanks for
finding this bug.

Can we close this CL?

Powered by Google App Engine
This is Rietveld 408576698