Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2625853003: [wasm] fix asm.js type for param type annotation statements (Closed)

Created:
3 years, 11 months ago by aseemgarg
Modified:
3 years, 11 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] fix asm.js type for param type annotation statements R=bradnelson@chromium.org BUG=v8:5809 Review-Url: https://codereview.chromium.org/2625853003 Cr-Commit-Position: refs/heads/master@{#42207} Committed: https://chromium.googlesource.com/v8/v8/+/b8a95b35456fffcbcfee0b4eafc67ea7c79cd32b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
aseemgarg
3 years, 11 months ago (2017-01-11 01:12:25 UTC) #3
bradnelson
lgtm
3 years, 11 months ago (2017-01-11 01:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625853003/1
3 years, 11 months ago (2017-01-11 01:13:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:36:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b8a95b35456fffcbcfee0b4eafc67ea7c79...

Powered by Google App Engine
This is Rietveld 408576698