[wasm] fix simd opcode read and error case for bad simd opcodes

[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org

Committed: https://crrev.com/1f6f345db29e96f6070ab8cef58e18ae7f879fe2
Cr-Commit-Position: refs/heads/master@{#40572}

[aseemgarg, 2016-10-24 20:16:35]

Andreas, this also fixes the fuzzer bug you found on your machine.

[gdeepti, 2016-10-24 20:54:26]

On 2016/10/24 20:16:35, aseemgarg wrote:
> Andreas, this also fixes the fuzzer bug you found on your machine.

Would it be possible to include the test as a part of the regression tests?

[gdeepti, 2016-10-24 21:43:33]

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:326: case kSimdPrefix: {
Probably good to gate this on CHECK_PROTOTYPE_OPCODE(wasm_simd_prototype) as
well.

[titzer, 2016-10-25 07:54:07]

lgtm

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:326: case kSimdPrefix: {
On 2016/10/24 21:43:32, gdeepti wrote:
> Probably good to gate this on CHECK_PROTOTYPE_OPCODE(wasm_simd_prototype) as
> well. 

Since this is just the length function, I think it's OK to leave it unguarded.

[ahaas, 2016-10-25 08:06:56]

On 2016/10/24 at 20:54:26, gdeepti wrote:
> On 2016/10/24 20:16:35, aseemgarg wrote:
> > Andreas, this also fixes the fuzzer bug you found on your machine.
> 
> Would it be possible to include the test as a part of the regression tests?

Thanks for fixing this issue. 
I think the bug id in the description should be chromium:658426. 
The best place for a test would be ast-decoder-unittest.cc.

[aseemgarg, 2016-10-25 18:44:06]

Description was changed from

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=v8:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org
==========

to

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org
==========

[aseemgarg, 2016-10-25 20:56:47]

Added tests in ast-decoder-unittest

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2447683004/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:326: case kSimdPrefix: {
On 2016/10/25 07:54:07, titzer wrote:
> On 2016/10/24 21:43:32, gdeepti wrote:
> > Probably good to gate this on CHECK_PROTOTYPE_OPCODE(wasm_simd_prototype) as
> > well. 
> 
> Since this is just the length function, I think it's OK to leave it unguarded.

Leaving as is. Can't use CHECK_PROTOTYPE_OPCODE as it has a break and don't see
the point of adding a lot of extra code if it is anyways ok to leave it
unguarded.

[aseemgarg, 2016-10-25 21:25:35]

The CQ bit was checked by aseemgarg@chromium.org

[aseemgarg, 2016-10-25 21:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2447683004/#ps20001
(title: "[wasm] fix simd opcode read and error case for bad simd opcodes")

[commit-bot: I haz the power, 2016-10-25 21:25:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 22:03:23]

Description was changed from

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org
==========

to

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org
==========

[commit-bot: I haz the power, 2016-10-25 22:03:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:13:01]

Description was changed from

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org
==========

to

==========
[wasm] fix simd opcode read and error case for bad simd opcodes

BUG=chromium:658426
R=ahaas@chromium.org,titzer@chromium.org,gdeepti@chromium.org

Committed: https://crrev.com/1f6f345db29e96f6070ab8cef58e18ae7f879fe2
Cr-Commit-Position: refs/heads/master@{#40572}
==========

[commit-bot: I haz the power, 2016-11-17 22:13:02]

Patchset 2 (id:??) landed as
https://crrev.com/1f6f345db29e96f6070ab8cef58e18ae7f879fe2
Cr-Commit-Position: refs/heads/master@{#40572}