Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1982293002: [wasm] remove extra nops in asm-wasm (Closed)

Created:
4 years, 7 months ago by aseemgarg
Modified:
4 years, 7 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] remove extra nops in asm-wasm R=bradnelson@chromium.org,titzer@chromium.org BUG=v8:4203 LOG=Y Committed: https://crrev.com/6e170c9fe18b753b2358ae572b6620817f56af2f Cr-Commit-Position: refs/heads/master@{#36282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/wasm/asm-wasm-builder.cc View 4 chunks +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1664993002 Patch 20001

Messages

Total messages: 11 (4 generated)
aseemgarg
4 years, 7 months ago (2016-05-17 12:42:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982293002/1
4 years, 7 months ago (2016-05-17 12:44:22 UTC) #3
titzer
lgtm
4 years, 7 months ago (2016-05-17 13:08:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 13:31:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982293002/1
4 years, 7 months ago (2016-05-17 14:03:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 14:05:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 14:06:48 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6e170c9fe18b753b2358ae572b6620817f56af2f
Cr-Commit-Position: refs/heads/master@{#36282}

Powered by Google App Engine
This is Rietveld 408576698