Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2101923003: [wasm] fix loops and if-else to take int type instead of signed (Closed)

Created:
4 years, 5 months ago by aseemgarg
Modified:
4 years, 5 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] fix loops and if-else to take int type instead of signed BUG=617526 R=bradnelson@chromium.org TEST=regress-617526.js Committed: https://crrev.com/fa5cb207a16896b0cf598fbcaef8e121d0ad4fd1 Cr-Commit-Position: refs/heads/master@{#37354}

Patch Set 1 #

Patch Set 2 : [wasm] fix loops and if-else to take int type instead of signed #

Total comments: 2

Patch Set 3 : [wasm] fix loops and if-else to take int type instead of signed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -4 lines) Patch
M src/typing-asm.cc View 1 2 4 chunks +16 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-617526.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
aseemgarg
4 years, 5 months ago (2016-06-28 07:34:16 UTC) #1
bradnelson
Might be worth a test or two beyond the regression one. https://codereview.chromium.org/2101923003/diff/20001/src/typing-asm.cc File src/typing-asm.cc (right): ...
4 years, 5 months ago (2016-06-28 15:07:57 UTC) #2
aseemgarg
https://codereview.chromium.org/2101923003/diff/20001/src/typing-asm.cc File src/typing-asm.cc (right): https://codereview.chromium.org/2101923003/diff/20001/src/typing-asm.cc#newcode343 src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->condition(), cache_.kAsmIntQ, On 2016/06/28 15:07:57, bradnelson wrote: > These ...
4 years, 5 months ago (2016-06-29 00:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101923003/40001
4 years, 5 months ago (2016-06-29 00:14:16 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-29 00:14:18 UTC) #7
bradnelson
lgtm
4 years, 5 months ago (2016-06-29 00:14:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101923003/40001
4 years, 5 months ago (2016-06-29 00:14:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 00:40:00 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:40:48 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa5cb207a16896b0cf598fbcaef8e121d0ad4fd1
Cr-Commit-Position: refs/heads/master@{#37354}

Powered by Google App Engine
This is Rietveld 408576698