Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2713613005: [wasm]implement simd lowering for F32x4 and I32x4 binops (Closed)

Created:
3 years, 10 months ago by aseemgarg
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm]implement simd lowering for F32x4 and I32x4 binops BUG=v8:4124 R=bradnelson@chromium.org,bbudge@chromium.org,gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2713613005 Cr-Commit-Position: refs/heads/master@{#43465} Committed: https://chromium.googlesource.com/v8/v8/+/7f5701507d96c1eddd2ba6e3a86ef1f382a5b4f8

Patch Set 1 #

Patch Set 2 : fix min/max test #

Patch Set 3 : [wasm]implement simd lowering for F32x4 and I32x4 binops #

Total comments: 2

Patch Set 4 : use namespace #

Total comments: 6

Patch Set 5 : comments #

Patch Set 6 : fix float args for win build #

Patch Set 7 : rebase #

Total comments: 2

Patch Set 8 : [wasm]implement simd lowering for F32x4 and I32x4 binops #

Patch Set 9 : [wasm]implement simd lowering for F32x4 and I32x4 binops #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -459 lines) Patch
M src/compiler/simd-scalar-lowering.cc View 1 2 3 4 5 6 2 chunks +40 lines, -14 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 3 4 9 12 chunks +1 line, -11 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 9 10 chunks +1 line, -11 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 5 6 7 28 chunks +420 lines, -97 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd-lowering.cc View 1 2 3 4 1 chunk +0 lines, -296 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 58 (40 generated)
aseemgarg
I32x4 Min and max functions are yet to be implemented. F32x4 min and max are ...
3 years, 10 months ago (2017-02-24 05:51:33 UTC) #3
bbudge
On 2017/02/24 05:51:33, aseemgarg wrote: > I32x4 Min and max functions are yet to be ...
3 years, 10 months ago (2017-02-24 06:03:00 UTC) #8
bbudge
On 2017/02/24 06:03:00, bbudge wrote: > On 2017/02/24 05:51:33, aseemgarg wrote: > > I32x4 Min ...
3 years, 10 months ago (2017-02-24 06:03:16 UTC) #9
aseemgarg
On 2017/02/24 06:03:16, bbudge wrote: > On 2017/02/24 06:03:00, bbudge wrote: > > On 2017/02/24 ...
3 years, 10 months ago (2017-02-24 08:49:57 UTC) #12
gdeepti
https://codereview.chromium.org/2713613005/diff/40001/test/cctest/wasm/test-wasm-simd-common.h File test/cctest/wasm/test-wasm-simd-common.h (right): https://codereview.chromium.org/2713613005/diff/40001/test/cctest/wasm/test-wasm-simd-common.h#newcode301 test/cctest/wasm/test-wasm-simd-common.h:301: class TestWasmSimdCommon { Maybe use a namespace here instead ...
3 years, 10 months ago (2017-02-24 13:31:23 UTC) #18
aseemgarg
https://codereview.chromium.org/2713613005/diff/40001/test/cctest/wasm/test-wasm-simd-common.h File test/cctest/wasm/test-wasm-simd-common.h (right): https://codereview.chromium.org/2713613005/diff/40001/test/cctest/wasm/test-wasm-simd-common.h#newcode301 test/cctest/wasm/test-wasm-simd-common.h:301: class TestWasmSimdCommon { On 2017/02/24 13:31:23, gdeepti wrote: > ...
3 years, 10 months ago (2017-02-24 14:19:42 UTC) #19
bbudge
I like your idea of merging the tests. Why not go further, and put all ...
3 years, 10 months ago (2017-02-24 20:53:36 UTC) #24
aseemgarg
Got rid of test-run-wasm-simd-lowering.cc and merged into test-run-wasm-simd. We don't need common anymore either https://codereview.chromium.org/2713613005/diff/60001/src/compiler/simd-scalar-lowering.cc ...
3 years, 10 months ago (2017-02-25 03:25:16 UTC) #25
bbudge
Nice, LGTM with 1 comment. https://codereview.chromium.org/2713613005/diff/120001/test/cctest/wasm/test-run-wasm-simd.cc File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2713613005/diff/120001/test/cctest/wasm/test-run-wasm-simd.cc#newcode231 test/cctest/wasm/test-run-wasm-simd.cc:231: x, kSimdPrefix, static_cast<byte>(kExprF32x4Splat) These ...
3 years, 9 months ago (2017-02-27 18:26:15 UTC) #38
aseemgarg
https://codereview.chromium.org/2713613005/diff/120001/test/cctest/wasm/test-run-wasm-simd.cc File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2713613005/diff/120001/test/cctest/wasm/test-run-wasm-simd.cc#newcode231 test/cctest/wasm/test-run-wasm-simd.cc:231: x, kSimdPrefix, static_cast<byte>(kExprF32x4Splat) On 2017/02/27 18:26:15, bbudge wrote: > ...
3 years, 9 months ago (2017-02-27 22:09:47 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713613005/140001
3 years, 9 months ago (2017-02-27 22:10:08 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35627)
3 years, 9 months ago (2017-02-27 22:13:19 UTC) #44
Mircea Trofin
On 2017/02/27 22:13:19, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-02-27 22:30:57 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713613005/180001
3 years, 9 months ago (2017-02-27 23:15:32 UTC) #52
commit-bot: I haz the power
Committed patchset #10 (id:180001) as https://chromium.googlesource.com/v8/v8/+/7f5701507d96c1eddd2ba6e3a86ef1f382a5b4f8
3 years, 9 months ago (2017-02-27 23:45:12 UTC) #55
Michael Achenbach
Note: This fails on arm chromebooks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2300 Please have a look.
3 years, 9 months ago (2017-02-28 16:20:08 UTC) #56
bbudge
On 2017/02/28 16:20:08, Michael Achenbach wrote: > Note: This fails on arm chromebooks: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2300 ...
3 years, 9 months ago (2017-02-28 16:38:32 UTC) #57
aseemgarg
3 years, 9 months ago (2017-02-28 21:28:12 UTC) #58
Message was sent while issue was closed.
On 2017/02/28 16:20:08, Michael Achenbach wrote:
> Note: This fails on arm chromebooks:
> https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2300
> 
> Please have a look.

This patch should fix it (disabled the failing tests for arm)
https://codereview.chromium.org/2723823002/

Powered by Google App Engine
This is Rietveld 408576698