Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1627643002: Revert of Refactoring gamepad polling to support dynamically added sources (Closed)

Created:
4 years, 11 months ago by bajones
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactoring gamepad polling to support dynamically added sources (patchset #5 id:80001 of https://codereview.chromium.org/1586663006/ ) Reason for revert: Some MSan bots started failing PepperGamepadHostTest.WaitForReply after landing this, I'm going to have to assume that it's related and look at it later next week. https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/6775 https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/13237 Original issue's description: > Refactoring gamepad polling to support dynamically added sources > > Also reduces duplicate code between platform data fetchers by having things like > sanitation happen in the provider, and makes the data fetchers themselves more > modular. > > BUG=577414 > > Committed: https://crrev.com/618039679323b6fc09e2146768f121661b0cdd41 > Cr-Commit-Position: refs/heads/master@{#371083} TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577414 Committed: https://crrev.com/3013c63965953c4fbf535eda79c1736a363681d7 Cr-Commit-Position: refs/heads/master@{#371138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1625 lines, -1720 lines) Patch
M content/browser/gamepad/gamepad_data_fetcher.h View 1 chunk +39 lines, -20 lines 0 comments Download
M content/browser/gamepad/gamepad_data_fetcher.cc View 1 chunk +74 lines, -8 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher.h View 1 chunk +18 lines, -18 lines 0 comments Download
A content/browser/gamepad/gamepad_platform_data_fetcher.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_android.cc View 3 chunks +39 lines, -39 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.h View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 8 chunks +28 lines, -29 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_mac.h View 3 chunks +31 lines, -11 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm View 14 chunks +174 lines, -64 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.h View 4 chunks +30 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.cc View 5 chunks +189 lines, -59 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.h View 8 chunks +30 lines, -74 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 10 chunks +68 lines, -149 lines 0 comments Download
M content/browser/gamepad/gamepad_provider_unittest.cc View 3 chunks +0 lines, -191 lines 0 comments Download
M content/browser/gamepad/gamepad_service.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_test_helpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_test_helpers.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.h View 4 chunks +8 lines, -15 lines 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.cc View 9 chunks +32 lines, -110 lines 0 comments Download
M content/browser/gamepad/xbox_data_fetcher_mac.h View 5 chunks +14 lines, -16 lines 0 comments Download
A content/browser/gamepad/xbox_data_fetcher_mac.cc View 1 chunk +809 lines, -0 lines 0 comments Download
D content/browser/gamepad/xbox_data_fetcher_mac.mm View 1 chunk +0 lines, -890 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bajones
Created Revert of Refactoring gamepad polling to support dynamically added sources
4 years, 11 months ago (2016-01-23 06:37:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627643002/1
4 years, 11 months ago (2016-01-23 06:38:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-23 06:39:04 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 06:40:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3013c63965953c4fbf535eda79c1736a363681d7
Cr-Commit-Position: refs/heads/master@{#371138}

Powered by Google App Engine
This is Rietveld 408576698