Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, asanka, tburkard+watch_chromium.org, tzik+watch_chromium.org, ahutter, browser-components-watch_chromium.org, Raman Kakilate, kinuko+watch, Ilya Sherman, yoshiki+watch_chromium.org, cbentzel+watch_chromium.org, benquan, jar (doing other things), benjhayden+dwatch_chromium.org, kkania, dbeam+watch-autofill_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), Raghu Simha, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, Albert Bodenhamer, haitaol1, gavinp+prer_chromium.org, tfarina, Aaron Boodman, dominich+watch_chromium.org, eroman, robertshield, Dane Wallinga, dyu1, estade+watch_chromium.org, mmenke
Visibility:
Public.

Description

Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" BUG=245942 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -270 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 72 chunks +143 lines, -132 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/extensions/external_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/operation_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/delete_directive_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/tracking_synchronizer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/external_policy_data_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_handle.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/oauth2_token_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_ui_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/shared_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive/local_change_processor_delegate.cc View 23 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_task_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/global_error_bubble.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/content_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+darin for review (mistakenly deleted the previous instance of this CL)
7 years, 6 months ago (2013-06-04 04:42:55 UTC) #1
akalin
TBRing!
7 years, 6 months ago (2013-06-04 04:43:18 UTC) #2
akalin
7 years, 6 months ago (2013-06-04 04:43:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r203849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698