chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

index 131b45a17da97b7e91732f8a26df1f3b2207327c..15f0ba6a0e68331788787c82e5fd9e3ed2fb30fc 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

@@ -172,7 +172,7 @@ void CloudPrintSetupFlow::OnDialogClosed(const std::string& json_retval) {

if (authenticator_.get())

authenticator_->CancelRequest();

- if (delegate_)

+ if (delegate_.get())

delegate_->OnDialogClosed();

delete this;

}

« no previous file with comments | « chrome/browser/prerender/prerender_handle.cc ('k') | chrome/browser/printing/print_dialog_cloud_unittest.cc » ('j') | no next file with comments »