chrome/browser/extensions/script_executor.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/script_executor.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/script_executor.cc

diff --git a/chrome/browser/extensions/script_executor.cc b/chrome/browser/extensions/script_executor.cc

index b35b77664065faba9921c4e5cfab6d5023c87179..9e4aecdcc2cf660a1757262ab5ae9494cfddcb04 100644

--- a/chrome/browser/extensions/script_executor.cc

+++ b/chrome/browser/extensions/script_executor.cc

@@ -76,7 +76,7 @@ class Handler : public content::WebContentsObserver {

int32 on_page_id,

const GURL& on_url,

const base::ListValue& script_result) {

- if (script_observers_ && error.empty()) {

+ if (script_observers_.get() && error.empty()) {

TabHelper::ScriptExecutionObserver::ExecutingScriptsMap id_map;

id_map[extension_id_] = std::set<std::string>();

FOR_EACH_OBSERVER(TabHelper::ScriptExecutionObserver, *script_observers_,

« no previous file with comments | « chrome/browser/extensions/external_install_ui.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | no next file with comments »