chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_file_sync_task_manager.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index ba4dcded08083edde6b76e4b385589beb299b093..61e156c94d9464fb9b91fac82f08b0087068929a 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -340,7 +340,7 @@ bool IsCardHolderNameValidForWallet(const string16& name) {

AutofillDialogController::~AutofillDialogController() {}

AutofillDialogControllerImpl::~AutofillDialogControllerImpl() {

- if (popup_controller_)

+ if (popup_controller_.get())

popup_controller_->Hide();

GetMetricLogger().LogDialogInitialUserState(

@@ -1299,7 +1299,7 @@ void AutofillDialogControllerImpl::UserEditedOrActivatedInput(

// If the user clicks while the popup is already showing, be sure to hide

// it.

- if (!was_edit && popup_controller_) {

+ if (!was_edit && popup_controller_.get()) {

HidePopup();

return;

}

@@ -1828,7 +1828,7 @@ void AutofillDialogControllerImpl::UpdateAccountChooserView() {

bool AutofillDialogControllerImpl::HandleKeyPressEventInInput(

const content::NativeWebKeyboardEvent& event) {

- if (popup_controller_)

+ if (popup_controller_.get())

return popup_controller_->HandleKeyPressEvent(event);

return false;

@@ -2372,7 +2372,7 @@ DetailInputs* AutofillDialogControllerImpl::MutableRequestedFieldsForSection(

}

void AutofillDialogControllerImpl::HidePopup() {

- if (popup_controller_)

+ if (popup_controller_.get())

popup_controller_->Hide();

input_showing_popup_ = NULL;

}