chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

index 3eea31dd5524fb092199452d10a3ea917450d7f2..958c55f0eec4df30949b53d1b79c39a82a626773 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

@@ -308,7 +308,7 @@ class AutofillDialogControllerTest : public testing::Test {

}

virtual void TearDown() OVERRIDE {

- if (controller_)

+ if (controller_.get())

controller_->ViewClosed();

}

@@ -324,7 +324,7 @@ class AutofillDialogControllerTest : public testing::Test {

}

void SetUpControllerWithFormData(const FormData& form_data) {

- if (controller_)

+ if (controller_.get())

controller_->ViewClosed();

base::Callback<void(const FormStructure*, const std::string&)> callback =

@@ -382,7 +382,7 @@ class AutofillDialogControllerTest : public testing::Test {

controller()->MenuModelForSection(SECTION_SHIPPING)->ActivatedAt(0);

}

- TestAutofillDialogController* controller() { return controller_; }

+ TestAutofillDialogController* controller() { return controller_.get(); }

TestingProfile* profile() { return &profile_; }