chrome/browser/sync/glue/shared_change_processor.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/shared_change_processor.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/non_ui_data_type_controller.cc ('k') | chrome/browser/sync/glue/ui_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/shared_change_processor.cc

diff --git a/chrome/browser/sync/glue/shared_change_processor.cc b/chrome/browser/sync/glue/shared_change_processor.cc

index f0c530921281ac6c327f227359e59506c324aff0..f8be7be98149137e1b82f8d3c6f1d2a495813246 100644

--- a/chrome/browser/sync/glue/shared_change_processor.cc

+++ b/chrome/browser/sync/glue/shared_change_processor.cc

@@ -64,7 +64,7 @@ base::WeakPtr<syncer::SyncableService> SharedChangeProcessor::Connect(

error_handler_ = error_handler;

base::WeakPtr<syncer::SyncableService> local_service =

sync_factory->GetSyncableServiceForType(type);

- if (!local_service) {

+ if (!local_service.get()) {

NOTREACHED() << "SyncableService destroyed before DTC was stopped.";

disconnected_ = true;

return base::WeakPtr<syncer::SyncableService>();

« no previous file with comments | « chrome/browser/sync/glue/non_ui_data_type_controller.cc ('k') | chrome/browser/sync/glue/ui_data_type_controller.cc » ('j') | no next file with comments »