chrome/browser/chrome_to_mobile_service.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_to_mobile_service.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/download/download_request_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_to_mobile_service.cc

diff --git a/chrome/browser/chrome_to_mobile_service.cc b/chrome/browser/chrome_to_mobile_service.cc

index dfb42f79ea008b10a5c2674fcbefe47a081ffabc..e2449c92a88b02eab278d2dff395d3e431768262 100644

--- a/chrome/browser/chrome_to_mobile_service.cc

+++ b/chrome/browser/chrome_to_mobile_service.cc

@@ -747,7 +747,7 @@ void ChromeToMobileService::HandleSubmitResponse(

// Check if the observer is waiting on a second response (url or snapshot).

for (RequestObserverMap::iterator other = request_observer_map_.begin();

observer.get() && (other != request_observer_map_.end()); ++other) {

- if (other->second == observer) {

+ if (other->second.get() == observer.get()) {

// Delay reporting success until the second response is received.

if (success)

return;