chrome/browser/sync/glue/history_model_worker.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/history_model_worker.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.cc ('k') | chrome/browser/sync/glue/non_ui_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/history_model_worker.cc

diff --git a/chrome/browser/sync/glue/history_model_worker.cc b/chrome/browser/sync/glue/history_model_worker.cc

index 656781a271290ec243c53c9d9207a584748c1d5b..13b5217cd564f2d764275a93222659cef78392c6 100644

--- a/chrome/browser/sync/glue/history_model_worker.cc

+++ b/chrome/browser/sync/glue/history_model_worker.cc

@@ -43,7 +43,7 @@ class WorkerTask : public history::HistoryDBTask {

class AddDBThreadObserverTask : public history::HistoryDBTask {

public:

- AddDBThreadObserverTask(HistoryModelWorker* history_worker)

+ explicit AddDBThreadObserverTask(HistoryModelWorker* history_worker)

: history_worker_(history_worker) {}

virtual bool RunOnDBThread(history::HistoryBackend* backend,

@@ -70,7 +70,7 @@ void PostWorkerTask(const base::WeakPtr<HistoryService>& history_service,

WaitableEvent* done,

syncer::SyncerError* error) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- if (history_service) {

+ if (history_service.get()) {

scoped_refptr<WorkerTask> task(new WorkerTask(work, done, error));

history_service->ScheduleDBTask(task.get(), cancelable_consumer);

} else {

« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.cc ('k') | chrome/browser/sync/glue/non_ui_data_type_controller.cc » ('j') | no next file with comments »