chrome/browser/extensions/external_install_ui.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_ui.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/external_install_ui.cc

diff --git a/chrome/browser/extensions/external_install_ui.cc b/chrome/browser/extensions/external_install_ui.cc

index 013b8c3f490c26f5eb9c6e5084dd01ff28adbdf5..97ba32bc9e4ece7078be2a4a4afb6925c087abdd 100644

--- a/chrome/browser/extensions/external_install_ui.cc

+++ b/chrome/browser/extensions/external_install_ui.cc

@@ -171,7 +171,7 @@ static void CreateExternalInstallGlobalError(

ExternalInstallDialogDelegate* delegate =

static_cast<ExternalInstallDialogDelegate*>(prompt_delegate);

ExternalInstallGlobalError* error_bubble = new ExternalInstallGlobalError(

- service, extension, delegate, prompt);

+ service.get(), extension, delegate, prompt);

error_service->AddGlobalError(error_bubble);

// Show bubble immediately if possible.

if (delegate->browser())

« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/browser/extensions/script_executor.cc » ('j') | no next file with comments »