chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc - Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 15987009: Update chrome/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('k') | chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

index 0a19afb14e01eef37decc04c71a6ae7ed136e4b4..cd4f8b525314d3f92c49aa408b87cf7f7f8b7c2e 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

@@ -365,14 +365,14 @@ TEST_F(AutofillPopupControllerUnitTest, GetOrCreate) {

AutofillPopupControllerImpl::GetOrCreate(

WeakPtr<AutofillPopupControllerImpl>(), delegate.GetWeakPtr(), NULL,

gfx::Rect());

- EXPECT_TRUE(controller);

+ EXPECT_TRUE(controller.get());

controller->Hide();

controller = AutofillPopupControllerImpl::GetOrCreate(

WeakPtr<AutofillPopupControllerImpl>(), delegate.GetWeakPtr(), NULL,

gfx::Rect());

- EXPECT_TRUE(controller);

+ EXPECT_TRUE(controller.get());

WeakPtr<AutofillPopupControllerImpl> controller2 =

AutofillPopupControllerImpl::GetOrCreate(controller,