Normalize _unittest.cc filename suffix for unittests

Normalize _unittest.cc filename suffix for unittests

This allows tools that use filename heuristics to detect tests
(like scythe)

BUG=335193
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245392

[alecflett, 2014-01-14 18:40:06]

This is just a rename of all _unittests.cc to _unittest.cc - this consistency
will let tools like scythe detect tests without a lot of inspection. This does
not rename any of the 27 run_all_unittests.cc files sprinkled around the tree
because those files seem like a gray area... they're test wrappers, but not
tests per say.

[piman, 2014-01-14 18:46:43]

lgtm

[willchan no longer on Chromium, 2014-01-14 18:51:59]

Base lgtm
On Jan 14, 2014 10:40 AM, <alecflett@chromium.org> wrote:

> Reviewers: piman, willchan, jam, darin,
>
> Message:
> This is just a rename of all _unittests.cc to _unittest.cc - this
> consistency
> will let tools like scythe detect tests without a lot of inspection. This
> does
> not rename any of the 27 run_all_unittests.cc files sprinkled around the
> tree
> because those files seem like a gray area... they're test wrappers, but not
> tests per say.
>
> Description:
> Normalize _unittest.cc filename suffix for unittests
>
> This allows tools that use filename heuristics to detect tests
> (like scythe)
>
> BUG=
>
> Please review this at https://codereview.chromium.org/138433004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+0, -4742 lines):
>   D android_webview/native/state_serializer_unittests.cc
>   D ash/test/ash_unittests.cc
>   D base/allocator/allocator_unittests.cc
>   D base/allocator/type_profiler_map_unittests.cc
>   D base/allocator/type_profiler_unittests.cc
>   D content/common/gpu/client/gl_helper_unittests.cc
>   D gpu/command_buffer/tests/gl_gpu_memory_buffer_unittests.cc
>   D gpu/command_buffer/tests/gl_lose_context_chromium_unittests.cc
>   D gpu/command_buffer/tests/gl_program_unittests.cc
>   D gpu/command_buffer/tests/gl_query_unittests.cc
>   D gpu/command_buffer/tests/gl_readback_unittests.cc
>   D gpu/command_buffer/tests/gl_shared_resources_unittests.cc
>   D gpu/command_buffer/tests/gl_stream_draw_unittests.cc
>   D gpu/command_buffer/tests/gl_texture_mailbox_unittests.cc
>   D gpu/command_buffer/tests/gl_texture_storage_unittests.cc
>   D gpu/command_buffer/tests/gl_unittests.cc
>   D gpu/command_buffer/tests/gl_virtual_contexts_unittests.cc
>   D gpu/command_buffer/tests/occlusion_query_unittests.cc
>   D mojo/public/tests/bindings/sample_service_unittests.cc
>   D ui/v2/src/v2_unittests.cc
>   M android_webview/android_webview_tests.gypi
>   A + android_webview/native/state_serializer_unittest.cc
>   M ash/ash.gyp
>   A + ash/test/ash_unittest.cc
>   M base/allocator/allocator.gyp
>   A + base/allocator/allocator_unittest.cc
>   A + base/allocator/type_profiler_map_unittest.cc
>   A + base/allocator/type_profiler_unittest.cc
>   A + content/common/gpu/client/gl_helper_unittest.cc
>   M content/content_tests.gypi
>   A + gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
>   A + gpu/command_buffer/tests/gl_lose_context_chromium_unittest.cc
>   A + gpu/command_buffer/tests/gl_program_unittest.cc
>   A + gpu/command_buffer/tests/gl_query_unittest.cc
>   A + gpu/command_buffer/tests/gl_readback_unittest.cc
>   A + gpu/command_buffer/tests/gl_shared_resources_unittest.cc
>   A + gpu/command_buffer/tests/gl_stream_draw_unittest.cc
>   A + gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc
>   A + gpu/command_buffer/tests/gl_texture_storage_unittest.cc
>   A + gpu/command_buffer/tests/gl_unittest.cc
>   A + gpu/command_buffer/tests/gl_virtual_contexts_unittest.cc
>   A + gpu/command_buffer/tests/occlusion_query_unittest.cc
>   M gpu/gpu.gyp
>   M mojo/mojo_public.gypi
>   A + mojo/public/tests/bindings/sample_service_unittest.cc
>   A + ui/v2/src/v2_unittest.cc
>   M ui/v2/v2.gyp
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jam, 2014-01-15 02:31:28]

content lgtm

[darin (slow to review), 2014-01-15 05:40:34]

LGTM except:

https://codereview.chromium.org/138433004/diff/100001/ash/test/ash_unittest.cc
File ash/test/ash_unittest.cc (right):

https://codereview.chromium.org/138433004/diff/100001/ash/test/ash_unittest.c...
ash/test/ash_unittest.cc:12: return base::LaunchUnitTestsSerially(
perhaps this one is more like a run_all_unittests.cc?

[commit-bot: I haz the power, 2014-01-16 21:04:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/138433004/150001

[commit-bot: I haz the power, 2014-01-17 00:30:34]

Change committed as 245392