Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update HTML canvas classes to use OVERRIDE / FINAL when needed Update HTML canvas classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164894

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -119 lines) Patch
M Source/core/html/canvas/ANGLEInstancedArrays.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/DOMPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/DataView.h View 2 chunks +4 lines, -6 lines 2 comments Download
M Source/core/html/canvas/EXTFragDepth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTTextureFilterAnisotropic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESElementIndexUint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESStandardDerivatives.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloat.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloatLinear.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloat.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloatLinear.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTexturePVRTC.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextAttributes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextObject.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugRendererInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDepthTexture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.h View 2 chunks +2 lines, -4 lines 2 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 2 chunks +26 lines, -26 lines 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/canvas/WebGLShader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLSharedObject.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 2 chunks +2 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 11 months ago (2014-01-09 17:08:50 UTC) #1
Inactive
6 years, 11 months ago (2014-01-10 18:51:46 UTC) #2
eseidel
lgtm https://codereview.chromium.org/131973002/diff/1/Source/core/html/canvas/DataView.h File Source/core/html/canvas/DataView.h (left): https://codereview.chromium.org/131973002/diff/1/Source/core/html/canvas/DataView.h#oldcode44 Source/core/html/canvas/DataView.h:44: virtual PassRefPtr<ArrayBufferView> slice(int, int) const { return 0; ...
6 years, 11 months ago (2014-01-10 19:11:22 UTC) #3
Inactive
https://codereview.chromium.org/131973002/diff/1/Source/core/html/canvas/DataView.h File Source/core/html/canvas/DataView.h (left): https://codereview.chromium.org/131973002/diff/1/Source/core/html/canvas/DataView.h#oldcode44 Source/core/html/canvas/DataView.h:44: virtual PassRefPtr<ArrayBufferView> slice(int, int) const { return 0; } ...
6 years, 11 months ago (2014-01-10 19:18:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131973002/1
6 years, 11 months ago (2014-01-10 19:20:14 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 19:26:50 UTC) #6
Message was sent while issue was closed. 
Change committed as 164894

Powered by Google App Engine
This is Rietveld 408576698