Update HTML canvas classes to use OVERRIDE / FINAL when needed

Source/core/html/canvas/DataView.h

Index: Source/core/html/canvas/DataView.h
diff --git a/Source/core/html/canvas/DataView.h b/Source/core/html/canvas/DataView.h
index 4a9728d845ec4c392b6febd4f7b4d9a5694bf11f..298e0dd44464921072d1f5eca644750fb4822ba9 100644
--- a/Source/core/html/canvas/DataView.h
+++ b/Source/core/html/canvas/DataView.h
@@ -34,14 +34,12 @@ namespace WebCore {
 
 class ExceptionState;
 
-class DataView : public ArrayBufferView, public ScriptWrappable {
+class DataView FINAL : public ArrayBufferView, public ScriptWrappable {
 public:
     static PassRefPtr<DataView> create(unsigned length);
     static PassRefPtr<DataView> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);
 
-    virtual unsigned length() const { return m_byteLength; }
-    virtual unsigned byteLength() const { return m_byteLength; }
-    virtual PassRefPtr<ArrayBufferView> slice(int, int) const { return 0; }

[eseidel, 2014/01/10 19:11:22]

Dead code?

[Inactive, 2014/01/10 19:18:26]

Yes, I noticed when I added OVERRIDE from that method. It does not override
anything and it cannot be overridden since this class is FINAL. Then I noticed
this is never called.

+    virtual unsigned byteLength() const OVERRIDE { return m_byteLength; }
 
     int8_t getInt8(unsigned byteOffset, ExceptionState&);
     uint8_t getUint8(unsigned byteOffset, ExceptionState&);
@@ -73,13 +71,13 @@ public:
     void setFloat64(unsigned byteOffset, double value, ExceptionState& ec) { setFloat64(byteOffset, value, false, ec); }
     void setFloat64(unsigned byteOffset, double value, bool littleEndian, ExceptionState&);
 
-    virtual ViewType getType() const
+    virtual ViewType getType() const OVERRIDE
     {
         return TypeDataView;
     }
 
 protected:
-    virtual void neuter();
+    virtual void neuter() OVERRIDE;
 
 private:
     DataView(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);