Source/core/html/canvas/WebGLFramebuffer.cpp - Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed

Unified Diff: Source/core/html/canvas/WebGLFramebuffer.cpp

Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLFramebuffer.h ('K') | « Source/core/html/canvas/WebGLFramebuffer.h ('k') | Source/core/html/canvas/WebGLLoseContext.h » ('j') | Source/core/html/canvas/WebGLVertexArrayObjectOES.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLFramebuffer.cpp

diff --git a/Source/core/html/canvas/WebGLFramebuffer.cpp b/Source/core/html/canvas/WebGLFramebuffer.cpp

index 14eaae23fa2cb01157da64665e799ed4b80bb9b8..2ebf094e3c74d004cd1044e0d4b065e5c5e8abcc 100644

--- a/Source/core/html/canvas/WebGLFramebuffer.cpp

+++ b/Source/core/html/canvas/WebGLFramebuffer.cpp

@@ -39,24 +39,24 @@ namespace {

return object ? object->object() : 0;

}

- class WebGLRenderbufferAttachment : public WebGLFramebuffer::WebGLAttachment {

+ class WebGLRenderbufferAttachment FINAL : public WebGLFramebuffer::WebGLAttachment {

public:

static PassRefPtr<WebGLFramebuffer::WebGLAttachment> create(WebGLRenderbuffer*);

private:

WebGLRenderbufferAttachment(WebGLRenderbuffer*);

- virtual GLsizei width() const;

- virtual GLsizei height() const;

- virtual GLenum format() const;

- virtual GLenum type() const;

- virtual WebGLSharedObject* object() const;

- virtual bool isSharedObject(WebGLSharedObject*) const;

- virtual bool valid() const;

- virtual bool initialized() const;

- virtual void setInitialized();

- virtual void onDetached(GraphicsContext3D*);

- virtual void attach(GraphicsContext3D*, GLenum attachment);

- virtual void unattach(GraphicsContext3D*, GLenum attachment);

+ virtual GLsizei width() const OVERRIDE;

+ virtual GLsizei height() const OVERRIDE;

+ virtual GLenum format() const OVERRIDE;

+ virtual GLenum type() const OVERRIDE;

+ virtual WebGLSharedObject* object() const OVERRIDE;

+ virtual bool isSharedObject(WebGLSharedObject*) const OVERRIDE;

+ virtual bool valid() const OVERRIDE;

+ virtual bool initialized() const OVERRIDE;

+ virtual void setInitialized() OVERRIDE;

+ virtual void onDetached(GraphicsContext3D*) OVERRIDE;

+ virtual void attach(GraphicsContext3D*, GLenum attachment) OVERRIDE;

+ virtual void unattach(GraphicsContext3D*, GLenum attachment) OVERRIDE;

WebGLRenderbufferAttachment() { };

@@ -152,24 +152,24 @@ namespace {

return 0;

}

- class WebGLTextureAttachment : public WebGLFramebuffer::WebGLAttachment {

+ class WebGLTextureAttachment FINAL : public WebGLFramebuffer::WebGLAttachment {