Source/core/html/canvas/WebGLProgram.h - Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLProgram.h

Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLFramebuffer.h ('K') | « Source/core/html/canvas/WebGLLoseContext.h ('k') | Source/core/html/canvas/WebGLRenderbuffer.h » ('j') | Source/core/html/canvas/WebGLVertexArrayObjectOES.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLProgram.h

diff --git a/Source/core/html/canvas/WebGLProgram.h b/Source/core/html/canvas/WebGLProgram.h

index d1742967cc5a9422c6bedf02a1d7b6581a0f3471..cf960af9286702383a22edefe418787da6e704f1 100644

--- a/Source/core/html/canvas/WebGLProgram.h

+++ b/Source/core/html/canvas/WebGLProgram.h

@@ -34,7 +34,7 @@

namespace WebCore {

-class WebGLProgram : public WebGLSharedObject, public ScriptWrappable {

+class WebGLProgram FINAL : public WebGLSharedObject, public ScriptWrappable {

public:

virtual ~WebGLProgram();

@@ -63,10 +63,10 @@ public:

protected:

WebGLProgram(WebGLRenderingContext*);

- virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject);

+ virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) OVERRIDE;

private:

- virtual bool isProgram() const { return true; }

+ virtual bool isProgram() const OVERRIDE { return true; }

void cacheActiveAttribLocations(GraphicsContext3D*);

void cacheInfoIfNeeded();