Update HTML canvas classes to use OVERRIDE / FINAL when needed

Source/core/html/canvas/DataView.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
 #define DataView_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "wtf/ArrayBufferView.h"
 #include "wtf/PassRefPtr.h"
 
 namespace WebCore {
 
 class ExceptionState;
 
-class DataView : public ArrayBufferView, public ScriptWrappable {
+class DataView FINAL : public ArrayBufferView, public ScriptWrappable {
 public:
     static PassRefPtr<DataView> create(unsigned length);
     static PassRefPtr<DataView> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);
 
-    virtual unsigned length() const { return m_byteLength; }
-    virtual unsigned byteLength() const { return m_byteLength; }
-    virtual PassRefPtr<ArrayBufferView> slice(int, int) const { return 0; }

[eseidel, 2014/01/10 19:11:22]

Dead code?

[Inactive, 2014/01/10 19:18:26]

Yes, I noticed when I added OVERRIDE from that method. It does not override
anything and it cannot be overridden since this class is FINAL. Then I noticed
this is never called.

+    virtual unsigned byteLength() const OVERRIDE { return m_byteLength; }
 
     int8_t getInt8(unsigned byteOffset, ExceptionState&);
     uint8_t getUint8(unsigned byteOffset, ExceptionState&);
     int16_t getInt16(unsigned byteOffset, ExceptionState& ec) { return getInt16(byteOffset, false, ec); }
     int16_t getInt16(unsigned byteOffset, bool littleEndian, ExceptionState&);
     uint16_t getUint16(unsigned byteOffset, ExceptionState& ec) { return getUint16(byteOffset, false, ec); }
     uint16_t getUint16(unsigned byteOffset, bool littleEndian, ExceptionState&);
     int32_t getInt32(unsigned byteOffset, ExceptionState& ec) { return getInt32(byteOffset, false, ec); }
     int32_t getInt32(unsigned byteOffset, bool littleEndian, ExceptionState&);
     uint32_t getUint32(unsigned byteOffset, ExceptionState& ec) { return getUint32(byteOffset, false, ec); }
@@ skipping 11 matching lines @@
     void setUint16(unsigned byteOffset, uint16_t value, bool littleEndian, ExceptionState&);
     void setInt32(unsigned byteOffset, int32_t value, ExceptionState& ec) { setInt32(byteOffset, value, false, ec); }
     void setInt32(unsigned byteOffset, int32_t value, bool littleEndian, ExceptionState&);
     void setUint32(unsigned byteOffset, uint32_t value, ExceptionState& ec) { setUint32(byteOffset, value, false, ec); }
     void setUint32(unsigned byteOffset, uint32_t value, bool littleEndian, ExceptionState&);
     void setFloat32(unsigned byteOffset, float value, ExceptionState& ec) { setFloat32(byteOffset, value, false, ec); }
     void setFloat32(unsigned byteOffset, float value, bool littleEndian, ExceptionState&);
     void setFloat64(unsigned byteOffset, double value, ExceptionState& ec) { setFloat64(byteOffset, value, false, ec); }
     void setFloat64(unsigned byteOffset, double value, bool littleEndian, ExceptionState&);
 
-    virtual ViewType getType() const
+    virtual ViewType getType() const OVERRIDE
     {
         return TypeDataView;
     }
 
 protected:
-    virtual void neuter();
+    virtual void neuter() OVERRIDE;
 
 private:
     DataView(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);
 
     template<typename T>
     inline bool beyondRange(unsigned byteOffset) const { return byteOffset >= m_byteLength || byteOffset + sizeof(T) > m_byteLength; }
 
     template<typename T>
     T getData(unsigned byteOffset, bool littleEndian, ExceptionState&) const;
 
     template<typename T>
     void setData(unsigned byteOffset, T value, bool littleEndian, ExceptionState&);
 
     unsigned m_byteLength;
 };
 
 
 } // namespace WebCore
 
 #endif // DataView_h