Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: Source/core/html/canvas/WebGLFramebuffer.h

Issue 131973002: Update HTML canvas classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLFramebuffer.h
diff --git a/Source/core/html/canvas/WebGLFramebuffer.h b/Source/core/html/canvas/WebGLFramebuffer.h
index fb91334ee23bf03c362a1fda944d29996de4c569..0a57b37846df639020761e0e679dd5869d6c45c6 100644
--- a/Source/core/html/canvas/WebGLFramebuffer.h
+++ b/Source/core/html/canvas/WebGLFramebuffer.h
@@ -37,7 +37,7 @@ namespace WebCore {
class WebGLRenderbuffer;
class WebGLTexture;
-class WebGLFramebuffer : public WebGLContextObject, public ScriptWrappable {
+class WebGLFramebuffer FINAL : public WebGLContextObject, public ScriptWrappable {
public:
class WebGLAttachment : public RefCounted<WebGLAttachment> {
public:
@@ -108,11 +108,9 @@ public:
protected:
WebGLFramebuffer(WebGLRenderingContext*);
- virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject);
+ virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) OVERRIDE;
private:
- virtual bool isFramebuffer() const { return true; }
eseidel 2014/01/10 19:11:22 Dead code?
Inactive 2014/01/10 19:18:26 Yes, it does not override anything and it is never
-
WebGLAttachment* getAttachment(GLenum) const;
bool isAttachmentComplete(WebGLAttachment* attachedObject, GLenum attachment, const char** reason) const;

Powered by Google App Engine
This is Rietveld 408576698