Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a custom pylintrc for build/android/. The default depot_tools pylintrc disables some checks that we can reasonably enable in build/android/. This CL does so. BUG= Committed: https://crrev.com/58b4d3677418a2360c23e118199f5cf8992d4178 Cr-Commit-Position: refs/heads/master@{#347720}

Patch Set 1 #

Total comments: 16

Patch Set 2 : perezju comments + rebase #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : fix appurify_sanitized import-errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -553 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/adb_install_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_reverse_forwarder.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/asan_symbolize.py View 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/avd.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 5 chunks +4 lines, -17 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/buildbot/bb_utils.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/devil/android/apk_helper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/devil/android/battery_utils.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/devil/android/battery_utils_test.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/devil/android/decorators.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/devil/android/decorators_test.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/devil/android/device_temp_file_test.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/devil/android/device_utils.py View 1 2 7 chunks +8 lines, -11 lines 0 comments Download
M build/android/devil/android/device_utils_device_test.py View 6 chunks +5 lines, -6 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 2 6 chunks +8 lines, -18 lines 0 comments Download
M build/android/devil/android/logcat_monitor.py View 2 chunks +1 line, -6 lines 0 comments Download
M build/android/devil/android/logcat_monitor_test.py View 1 9 chunks +17 lines, -15 lines 0 comments Download
M build/android/devil/android/md5sum.py View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/devil/android/md5sum_test.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/devil/android/ports.py View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/devil/android/sdk/aapt.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/devil/android/sdk/adb_wrapper.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/devil/android/sdk/shared_prefs.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/devil/android/sdk/shared_prefs_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/android/sdk/split_select.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/devil/base_error.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/devil/utils/lsusb.py View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/android/devil/utils/reraiser_thread_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/devil/utils/reset_usb.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/devil/utils/timeout_retry.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/emma_coverage_stats.py View 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/emma_coverage_stats_test.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/findbugs_diff.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/generate_v14_compatible_resources.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/lint.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/incremental_install.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/install_emulator_deps.py View 3 chunks +5 lines, -5 lines 0 comments Download
M build/android/lighttpd_server.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/lint/suppress.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/method_count.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/preprocess_google_play_services.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/provision_devices.py View 5 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/base/test_dispatcher_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/content_settings.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/device/commands/install_commands.py View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M build/android/pylib/device_settings.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/forwarder.py View 3 chunks +5 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 5 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/test_package.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 2 chunks +1 line, -5 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/host_driven/test_server.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_parser.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 4 chunks +3 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/json_perf_parser.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 3 chunks +6 lines, -4 lines 0 comments Download
M build/android/pylib/junit/test_dispatcher.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/linker/test_case.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/linker/test_runner.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/perf/cache_control.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/perf/perf_control.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/perf/setup.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 1 chunk +0 lines, -5 lines 0 comments Download
D build/android/pylib/perf/surface_stats_collector_unittest.py View 1 chunk +0 lines, -64 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/remote/device/appurify_constants.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/appurify_sanitized.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_environment.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 2 chunks +2 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_instrumentation_test_run.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 6 chunks +5 lines, -6 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_uirobot_test_run.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/results/flakiness_dashboard/json_results_generator.py View 5 chunks +8 lines, -9 lines 0 comments Download
A + build/android/pylib/results/flakiness_dashboard/json_results_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/results/flakiness_dashboard/results_uploader.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/results/report_results.py View 3 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/screenshot.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/uirobot/uirobot_test_instance.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 2 chunks +1 line, -4 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 1 chunk +0 lines, -4 lines 0 comments Download
D build/android/pylib/utils/json_results_generator_unittest.py View 1 chunk +0 lines, -213 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +2 lines, -2 lines 0 comments Download
A build/android/pylintrc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M build/android/screenshot.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/symbolize.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/test_runner.py View 1 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/tombstones.py View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/update_verification.py View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jbudorick
5 years, 3 months ago (2015-09-03 20:10:54 UTC) #2
perezju
This is fantastic! Great cleanup! There are a few warnings that we tend to disable ...
5 years, 3 months ago (2015-09-04 09:01:54 UTC) #3
jbudorick
https://codereview.chromium.org/1315743004/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/1315743004/diff/1/build/android/buildbot/bb_device_steps.py#newcode729 build/android/buildbot/bb_device_steps.py:729: global CHROME_OUT_DIR On 2015/09/04 at 09:01:53, perezju wrote: > ...
5 years, 3 months ago (2015-09-04 16:51:56 UTC) #4
perezju
lgtm! https://codereview.chromium.org/1315743004/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/1315743004/diff/1/build/android/buildbot/bb_device_steps.py#newcode729 build/android/buildbot/bb_device_steps.py:729: global CHROME_OUT_DIR On 2015/09/04 16:51:55, jbudorick wrote: > ...
5 years, 3 months ago (2015-09-08 13:40:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315743004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315743004/40001
5 years, 3 months ago (2015-09-08 14:15:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/97305)
5 years, 3 months ago (2015-09-08 15:23:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315743004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315743004/60001
5 years, 3 months ago (2015-09-08 15:29:58 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-08 16:45:08 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 16:46:03 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/58b4d3677418a2360c23e118199f5cf8992d4178
Cr-Commit-Position: refs/heads/master@{#347720}

Powered by Google App Engine
This is Rietveld 408576698