Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3090)

Unified Diff: build/android/buildbot/bb_utils.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | build/android/devil/android/apk_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_utils.py
diff --git a/build/android/buildbot/bb_utils.py b/build/android/buildbot/bb_utils.py
index 3c16cc2bc5b243d4db1c7b1eeb8f3c5a948862c1..b78fec036b69fe8e04edeeaea6c85ae3b73a4ca7 100644
--- a/build/android/buildbot/bb_utils.py
+++ b/build/android/buildbot/bb_utils.py
@@ -5,13 +5,13 @@
import json
import optparse
import os
-import pipes
import subprocess
import sys
import bb_annotations
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
+from devil.utils import cmd_helper
from pylib import constants
@@ -33,7 +33,7 @@ GSUTIL_PATH = os.path.join(BB_BUILD_DIR, 'third_party', 'gsutil', 'gsutil')
def CommandToString(command):
"""Returns quoted command that can be run in bash shell."""
- return ' '.join(map(pipes.quote, command))
+ return ' '.join(cmd_helper.SingleQuote(c) for c in command)
def SpawnCmd(command, stdout=None, cwd=CHROME_SRC):
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | build/android/devil/android/apk_helper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698