build/android/pylib/remote/device/remote_device_environment.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/remote/device/remote_device_environment.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/remote/device/appurify_sanitized.py ('k') | build/android/pylib/remote/device/remote_device_gtest_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/remote/device/remote_device_environment.py

diff --git a/build/android/pylib/remote/device/remote_device_environment.py b/build/android/pylib/remote/device/remote_device_environment.py

index e5bfa6a3f88cab516e886251f30e0c563f3f0e2a..97c1e59be522db11e7bf883f1c0f243c4c40a10a 100644

--- a/build/android/pylib/remote/device/remote_device_environment.py

+++ b/build/android/pylib/remote/device/remote_device_environment.py

@@ -13,7 +13,6 @@ import sys

from devil.utils import reraiser_thread

from devil.utils import timeout_retry

-from pylib import constants

from pylib.base import environment

from pylib.remote.device import appurify_sanitized

from pylib.remote.device import remote_device_helper

@@ -280,7 +279,7 @@ class RemoteDeviceEnvironment(environment.Environment):

timeout_retry.WaitFor(self._FindDevice, wait_period=1)

def _PrintAvailableDevices(self, device_list):

- def compare_devices(a,b):

+ def compare_devices(a, b):

for key in ('os_version', 'name'):

c = cmp(a[key], b[key])

if c:

@@ -331,7 +330,7 @@ class RemoteDeviceEnvironment(environment.Environment):

return self._network_config

@property

- def only_output_failures(self):

+ def only_output_failures(self): # pylint: disable=no-self-use

# TODO(jbudorick): Remove this once b/18981674 is fixed.

return True