Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: build/android/devil/android/ports.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/devil/android/md5sum_test.py ('k') | build/android/devil/android/sdk/aapt.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/devil/android/ports.py
diff --git a/build/android/devil/android/ports.py b/build/android/devil/android/ports.py
index 49ee4e34e376c3471632ceb35bf6ce013feedaf2..eff30ced0f53ec0845070fb37aef02e5d9993146 100644
--- a/build/android/devil/android/ports.py
+++ b/build/android/devil/android/ports.py
@@ -37,8 +37,8 @@ def ResetTestServerPortAllocation():
if os.path.exists(_TEST_SERVER_PORT_LOCKFILE):
os.unlink(_TEST_SERVER_PORT_LOCKFILE)
return True
- except Exception as e:
- logging.error(e)
+ except Exception: # pylint: disable=broad-except
+ logging.exception('Error while resetting port allocation')
return False
@@ -69,8 +69,8 @@ def AllocateTestServerPort():
else:
fp.seek(0, os.SEEK_SET)
fp.write('%d' % (port + 1))
- except Exception as e:
- logging.error(e)
+ except Exception: # pylint: disable=broad-except
+ logging.exception('ERror while allocating port')
finally:
if fp_lock:
fcntl.flock(fp_lock, fcntl.LOCK_UN)
« no previous file with comments | « build/android/devil/android/md5sum_test.py ('k') | build/android/devil/android/sdk/aapt.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698