build/android/pylib/results/flakiness_dashboard/results_uploader.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/results/flakiness_dashboard/results_uploader.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/results/flakiness_dashboard/json_results_generator_unittest.py ('k') | build/android/pylib/results/json_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/results/flakiness_dashboard/results_uploader.py

diff --git a/build/android/pylib/results/flakiness_dashboard/results_uploader.py b/build/android/pylib/results/flakiness_dashboard/results_uploader.py

index 965ddcf2a09aa74379bb5f3ec0d1afabf43a53ce..1360b80927d16288541cc98e659fbb6180251858 100644

--- a/build/android/pylib/results/flakiness_dashboard/results_uploader.py

+++ b/build/android/pylib/results/flakiness_dashboard/results_uploader.py

@@ -162,8 +162,8 @@ class ResultsUploader(object):

results_generator.GenerateJSONOutput()

results_generator.GenerateTimesMSFile()

results_generator.UploadJSONFiles(json_files)

- except Exception as e:

- logging.error("Uploading results to test server failed: %s." % e)

+ except Exception as e: # pylint: disable=broad-except

+ logging.error("Uploading results to test server failed: %s.", e)

finally:

shutil.rmtree(tmp_folder)