Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: build/android/devil/android/device_temp_file_test.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/devil/android/decorators_test.py ('k') | build/android/devil/android/device_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/devil/android/device_temp_file_test.py
diff --git a/build/android/devil/android/device_temp_file_test.py b/build/android/devil/android/device_temp_file_test.py
index 791f3eb025bdf4cfce6f08712a16e69dc10563c1..76f9cc8ec0179984831eff7fd3028299487fc3e3 100755
--- a/build/android/devil/android/device_temp_file_test.py
+++ b/build/android/devil/android/device_temp_file_test.py
@@ -13,8 +13,8 @@ import sys
import unittest
from devil.android import device_errors
+from devil.android import device_temp_file
from devil.android.sdk import adb_wrapper
-from devil.utils import device_temp_file
from devil.utils import mock_calls
from pylib import constants
@@ -70,7 +70,7 @@ class DeviceTempFileTest(mock_calls.TestCase):
self.mockShellCall('touch '),
self.mockShellCall('rm -f ')):
with device_temp_file.DeviceTempFile(self.adb) as tmpfile:
- logging.debug('Temp file name: %s' % tmpfile.name)
+ logging.debug('Temp file name: %s', tmpfile.name)
def testTempFileLifecycle(self):
with self.assertCalls(
@@ -80,7 +80,7 @@ class DeviceTempFileTest(mock_calls.TestCase):
tempFileContextManager = device_temp_file.DeviceTempFile(self.adb)
with mock.patch.object(self.adb, 'Shell'):
with tempFileContextManager as tmpfile:
- logging.debug('Temp file name: %s' % tmpfile.name)
+ logging.debug('Temp file name: %s', tmpfile.name)
self.assertEquals(0, self.adb.Shell.call_count)
self.assertEquals(1, self.adb.Shell.call_count)
args, _ = self.adb.Shell.call_args
« no previous file with comments | « build/android/devil/android/decorators_test.py ('k') | build/android/devil/android/device_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698