build/android/pylib/host_driven/test_server.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/host_driven/test_server.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/host_driven/test_runner.py ('k') | build/android/pylib/instrumentation/instrumentation_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/host_driven/test_server.py

diff --git a/build/android/pylib/host_driven/test_server.py b/build/android/pylib/host_driven/test_server.py

index 07835000fd95e940a65ce79bb538de8aecf69b55..af58ddc2656548612a3fdf9c607c2db06c5a1b5a 100644

--- a/build/android/pylib/host_driven/test_server.py

+++ b/build/android/pylib/host_driven/test_server.py

@@ -117,11 +117,11 @@ class TestServer(object):

while retries < 5:

try:

d = urllib2.urlopen(test_url).read()

- logging.info('URL %s GOT: %s' % (test_url, d))

+ logging.info('URL %s GOT: %s', test_url, d)

if d.startswith(expected_response):

break

- except Exception as e:

- logging.info('URL %s GOT: %s' % (test_url, e))

+ except Exception as e: # pylint: disable=broad-except

+ logging.info('URL %s GOT: %s', test_url, e)

time.sleep(retries * 0.1)

retries += 1

« no previous file with comments | « build/android/pylib/host_driven/test_runner.py ('k') | build/android/pylib/instrumentation/instrumentation_parser.py » ('j') | no next file with comments »