build/android/pylib/perf/test_runner.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/test_runner.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/perf/test_runner.py

diff --git a/build/android/pylib/perf/test_runner.py b/build/android/pylib/perf/test_runner.py

index 2e89e6934368c40431b6b759cbf596395981fd06..80a89a38d565d4669e539ccf0233482013784444 100644

--- a/build/android/pylib/perf/test_runner.py

+++ b/build/android/pylib/perf/test_runner.py

@@ -258,7 +258,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

logging.warning('Unmapping device ports')

forwarder.Forwarder.UnmapAllDevicePorts(self.device)

self.device.RestartAdbd()

- except Exception as e:

+ except Exception as e: # pylint: disable=broad-except

logging.error('Exception when tearing down device %s', e)

cmd = ('%s --device %s' %

@@ -330,7 +330,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

try:

self.device.WaitUntilFullyBooted(timeout=120)

except device_errors.CommandTimeoutError as e:

- logging.error('Device failed to return after %s: %s' % (test_name, e))

+ logging.error('Device failed to return after %s: %s', test_name, e)

actual_exit_code = exit_code

if test_name in self._flaky_tests:

« no previous file with comments | « build/android/pylib/perf/surface_stats_collector_unittest.py ('k') | build/android/pylib/perf/thermal_throttle.py » ('j') | no next file with comments »