build/android/pylib/utils/test_environment.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/test_environment.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix appurify_sanitized import-errors Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/utils/test_environment.py

diff --git a/build/android/pylib/utils/test_environment.py b/build/android/pylib/utils/test_environment.py

index 5976755f9b4071ba835ac0a169fde91d411f8c15..2ba96afed05065b3cd2ad46fa343b60576af55f1 100644

--- a/build/android/pylib/utils/test_environment.py

+++ b/build/android/pylib/utils/test_environment.py

@@ -21,12 +21,12 @@ def _KillWebServers():

logging.info('Killing %s %s %s', s, server, p.pid)

p.send_signal(s)

signalled.append(p)

- except Exception:

+ except Exception: # pylint: disable=broad-except

logging.exception('Failed killing %s %s', server, p.pid)

for p in signalled:

try:

p.wait(1)

- except Exception:

+ except Exception: # pylint: disable=broad-except

logging.exception('Failed waiting for %s to die.', p.pid)

« no previous file with comments | « build/android/pylib/utils/json_results_generator_unittest.py ('k') | build/android/pylintrc » ('j') | no next file with comments »