Index: build/android/pylib/results/report_results.py |
diff --git a/build/android/pylib/results/report_results.py b/build/android/pylib/results/report_results.py |
index 371ab9618a60ecc50721df48f9f243b6df606094..76e4bb5444333a63faaf1e600f75c83cb3ec38e4 100644 |
--- a/build/android/pylib/results/report_results.py |
+++ b/build/android/pylib/results/report_results.py |
@@ -24,9 +24,9 @@ def _LogToFile(results, test_type, suite_name): |
print >> log_file, '\n%s results for %s build %s:' % ( |
test_type, os.environ.get('BUILDBOT_BUILDERNAME'), |
os.environ.get('BUILDBOT_BUILDNUMBER')) |
- logging.info('Writing results to %s.' % full_file_name) |
+ logging.info('Writing results to %s.', full_file_name) |
- logging.info('Writing results to %s.' % full_file_name) |
+ logging.info('Writing results to %s.', full_file_name) |
with open(full_file_name, 'a') as log_file: |
shortened_suite_name = suite_name[:25] + (suite_name[25:] and '...') |
print >> log_file, '%s%s' % (shortened_suite_name.ljust(30), |
@@ -36,8 +36,8 @@ def _LogToFile(results, test_type, suite_name): |
def _LogToFlakinessDashboard(results, test_type, test_package, |
flakiness_server): |
"""Upload results to the flakiness dashboard""" |
- logging.info('Upload results for test type "%s", test package "%s" to %s' % |
- (test_type, test_package, flakiness_server)) |
+ logging.info('Upload results for test type "%s", test package "%s" to %s', |
+ test_type, test_package, flakiness_server) |
try: |
if test_type == 'Instrumentation': |
@@ -62,8 +62,8 @@ def _LogToFlakinessDashboard(results, test_type, test_package, |
results_uploader.Upload( |
results, flakiness_server, dashboard_test_type) |
- except Exception as e: |
- logging.error(e) |
+ except Exception: # pylint: disable=broad-except |
+ logging.exception('Failure while logging to %s', flakiness_server) |
def LogFull(results, test_type, test_package, annotation=None, |