Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed)

Created:
5 years, 3 months ago by dmazzoni
Modified:
5 years, 3 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make earcon ids strings instead of numbers. BUG=491243 Committed: https://crrev.com/b36f1f53ef2e73c6b09e41170832ac1196404a39 Cr-Commit-Position: refs/heads/master@{#346245}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add guard for cvox.ApiImplementation, rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -342 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/aria_util.js View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/description_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/earcon_util.js View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/nav_description.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/nav_math_description.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/page_selection.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_earcons.js View 1 4 chunks +37 lines, -280 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/testing/earcons.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/math_shifter.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/table_shifter.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 15 (6 generated)
dmazzoni
5 years, 3 months ago (2015-08-27 18:15:51 UTC) #2
Peter Lundblad
lgtm https://codereview.chromium.org/1306773003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js (right): https://codereview.chromium.org/1306773003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js#newcode202 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js:202: cvox.ChromeVox.earcons.playEarcon(cvox.Earcon[earcon]); Should guard against passing in undefined to ...
5 years, 3 months ago (2015-08-27 19:54:56 UTC) #3
dmazzoni
https://codereview.chromium.org/1306773003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js (right): https://codereview.chromium.org/1306773003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js#newcode202 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js:202: cvox.ChromeVox.earcons.playEarcon(cvox.Earcon[earcon]); On 2015/08/27 19:54:56, Peter Lundblad wrote: > Should ...
5 years, 3 months ago (2015-08-27 21:27:47 UTC) #4
Peter Lundblad
lgtm
5 years, 3 months ago (2015-08-27 21:37:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306773003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306773003/50001
5 years, 3 months ago (2015-08-27 22:23:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/56017)
5 years, 3 months ago (2015-08-27 23:07:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306773003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306773003/70001
5 years, 3 months ago (2015-08-28 21:26:21 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 3 months ago (2015-08-28 21:57:23 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 21:57:59 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b36f1f53ef2e73c6b09e41170832ac1196404a39
Cr-Commit-Position: refs/heads/master@{#346245}

Powered by Google App Engine
This is Rietveld 408576698