chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js - Issue 1306773003: Make earcon ids strings instead of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons

Patch Set: Fixed test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js

index da44a57141d66f9d36c3fee40248b9bf6987d31f..475ad98dfaf7025d31993886bf81536ba3c908f9 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/widget.js

@@ -93,7 +93,7 @@ cvox.Widget.prototype.show = function() {

andMessage(this.getHelpMsg()).

speakFlush();

}

- cvox.ChromeVox.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_OPEN);

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_OPEN);

this.active = true;

};

@@ -110,7 +110,7 @@ cvox.Widget.prototype.hide = function(opt_noSync) {

window.removeEventListener('keydown', this.onKeyDown, true);

cvox.ChromeVox.stickyOverride = null;

- cvox.ChromeVox.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_CLOSE);

+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_CLOSE);

if (!opt_noSync) {

this.initialNode = this.initialNode.nodeType == 1 ?

this.initialNode : this.initialNode.parentNode;